Skip to content

dtype coverage for mixed topology tests#4194

Merged
schnellerhase merged 7 commits intoFEniCS:mainfrom
Siya-05:mixed-topology-tests-pr
Apr 30, 2026
Merged

dtype coverage for mixed topology tests#4194
schnellerhase merged 7 commits intoFEniCS:mainfrom
Siya-05:mixed-topology-tests-pr

Conversation

@Siya-05
Copy link
Copy Markdown
Contributor

@Siya-05 Siya-05 commented Apr 30, 2026

Summary

Add dtype coverage (float32 and float64) to selected mixed-topology mesh tests.

Changes

  • Parametrized:

    • test_create_mixed_mesh
    • test_mixed_topology_mesh
  • Updated:

    • Geometry arrays to use dtype
    • coordinate_element(..., dtype=dtype)
  • Kept:

    • Topology/index arrays as int64 (unchanged)

Rationale

  • These tests operate at the mesh/geometry level and are naturally dtype-agnostic, making them suitable for dtype parametrization.
  • FEM-level tests (e.g., dofmap tests) were explored but not included due to current limitations:
    Basix UFL elements default to float64, leading to dtype mismatches when using float32.

@schnellerhase schnellerhase added the housekeeping Tidying and style improvements label Apr 30, 2026
@schnellerhase
Copy link
Copy Markdown
Contributor

Ref #4098.

Comment thread python/test/unit/mesh/test_create_mixed_mesh.py Outdated
Comment thread python/test/unit/mesh/test_create_mixed_mesh.py Outdated
Siya-05 and others added 3 commits April 30, 2026 19:14
Co-authored-by: Paul T. Kühner <56360279+schnellerhase@users.noreply.github.com>
Co-authored-by: Paul T. Kühner <56360279+schnellerhase@users.noreply.github.com>
@schnellerhase
Copy link
Copy Markdown
Contributor

Thanks, almost all done 😄

@schnellerhase schnellerhase enabled auto-merge April 30, 2026 13:47
@schnellerhase schnellerhase added this pull request to the merge queue Apr 30, 2026
@Siya-05
Copy link
Copy Markdown
Contributor Author

Siya-05 commented Apr 30, 2026

Thanks for the quick review! Really appreciate it.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2026
@schnellerhase schnellerhase enabled auto-merge April 30, 2026 14:32
@schnellerhase schnellerhase added this pull request to the merge queue Apr 30, 2026
Merged via the queue into FEniCS:main with commit 5ad409a Apr 30, 2026
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Tidying and style improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants